Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tests, restore Alpine tests, fix PHP 8.1+ deprecation warning #39

Merged
merged 9 commits into from
Sep 19, 2023

Conversation

mlocati
Copy link
Contributor

@mlocati mlocati commented Sep 13, 2023

Fix #35

@27pchrisl
Copy link
Contributor

Hi @mlocati, I was checking out this very welcome PR with the code below that segfaults on PHP 8.2 on Ubuntu and MacOS. Was this a 8.2 compatibility fault that this PR will address or is it a different area of work?

<?php

$matrix = Tensor\Matrix::ones(2,2);
$matrix->inverse();

Thankyou!

@mlocati
Copy link
Contributor Author

mlocati commented Sep 17, 2023

Was this a 8.2 compatibility fault that this PR will address or is it a different area of work?

Nope, I just fixed a couple of deprecation warnings about classes extending ArrayAccess / IteratorAggregate

@mlocati mlocati mentioned this pull request Sep 17, 2023
@andrewdalpino
Copy link
Member

Thank you @mlocati!

@andrewdalpino andrewdalpino merged commit 50325a9 into RubixML:master Sep 19, 2023
21 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Sep 19, 2023
@mlocati mlocati deleted the fixes branch September 19, 2023 05:07
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ext compilation errors and warning - PHP 8.1
4 participants