Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the encoding system! #54

Closed
tarcieri opened this issue Apr 22, 2013 · 2 comments · Fixed by #65
Closed

Remove the encoding system! #54

tarcieri opened this issue Apr 22, 2013 · 2 comments · Fixed by #65

Comments

@tarcieri
Copy link
Contributor

It's agreed, the encoding system must go!
@dchapman1988
Copy link

It's more of a convenience feature than it is a crypto feature. Maybe it should be removed? I don't know, my philosophical prowess isn't strong enough here.

@namelessjon
Copy link
Contributor

I find the encoding stuff useful to have, but it does make some of the APIs very untidy. I think an API which returns first class Ciphertext, AuthenticationTag, Signature classes could be a good compromise. They would behave very much like strings, respond to #to_s and #to_str, but those would also take an extra and optional argument, similar to the current Keys. They'd also provide things like a #primitive method.

tarcieri added a commit that referenced this issue Aug 8, 2013
@tarcieri
Remove the encoding system
9b08bc7 
After much discussion it was agreed that the encoding system was out of place in
this library.

This commit removes it, and hopefully improves the general quality of the
codebase as well. All encoding-related thunks and glue code have been removed,
the way TestVectors work have been standardized, and any stray test vectors
still lingering inside of the tests have been moved to test_vectors.rb

Fixes #54
@tarcieri tarcieri mentioned this issue Aug 8, 2013
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove the encoding system RubyCrypto/rbnacl
3 participants
@tarcieri @namelessjon @dchapman1988