Last minute changes to the ChaCha20Poly1305 API #148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unfortunately I already shipped 4.0.0. Technically this is a semantic versioning violation. However, the API is not yet documented and there have only been 40 downloads of 4.0.0, so I think it's still safe to ship some last-minute changes nobody will complain about (I hope!) - Add "Legacy" to the old ChaCha20Poly1305 API to impart it shouldn't be used except for compatibility reasons - Capitalize both 'C's in ChaCha - Rename the base class of AEAD ciphers to `RbNaCl::AEAD::Base`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unfortunately I already shipped 4.0.0. Technically this is a semantic versioning violation. However, the API is not yet documented and there have only been 40 downloads of 4.0.0, so I think it's still safe to ship some last-minute changes nobody will complain about (I hope!)
RbNaCl::AEAD::Base