Added functions to the SigninKey and to the VeryKey classes for signe… #197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d messages Added functions sign_full and verify_full to work with messages combined with their signatures, in comparison to the sign and verify.
tarcieri
reviewed
Jun 10, 2019
| # @param message [String] Message to be signed by this key | ||
| # | ||
| # @return [String] Signature and the message as bytes | ||
| def sign_full(message) |
There was a problem hiding this comment.
Since the provided functionality is attached signatures, I think a name like sign_attached (and and correspondingly verify_attached) would make more sense.
|
FYI, I'm still interested in merging this, however I'd like the method names changed if you agree |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…d messages
Added functions sign_full and verify_full to work with messages combined with
their signatures, in comparison to the sign and verify.
The original interface works with detached signatures. Some of the users
might be used to work with a combination of a signature and a message.
This commit enables this opportunity.