Extract parts of long Monetize#extract_cents into methods #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
allolex
commented
Apr 18, 2014
allolex
commented
- Moved regular expression into constant
- Used regexes more idiomatically, e.g. \D instead of [^\d]
- .negative? tells you whether the number is negative
- .contains_hyphen? tells you whether the number contains a hyphen
- .strip_negative_symbols removes minus signs from numbers
- Moved regular expression into constant - Used regexes more idiomatically, e.g. \D instead of [^\d] - .negative? tells you whether the number is negative - .contains_hyphen? tells you whether the number contains a hyphen - .strip_negative_symbols removes minus signs from numbers
|
When I get a chance, I'll have a go at tidying up the code that recognises what is what based on the delimiters. :) |
| num = input.gsub(/[^\d.,'-]/, '') | ||
|
|
||
| negative = num =~ /^-|-$/ ? true : false | ||
| @original_number = num = input.gsub(/[^\d.,'-]/, '') |
There was a problem hiding this comment.
Only question I have, why an instance variable here? Why not make a memoized method instead?
There was a problem hiding this comment.
Good point. To be honest, I plan to factor that variable out as well. It
was just easy to do it this way. These are just the first steps.
For now, why don't you just leave the PR unmerged and I'll stick my other
changes in the same branch so they show up here?
Damon Davison
http://allolex.net
@allolex
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.