Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dependent slots to Deliberation PSOA RuleML #78

Closed
greenTara opened this issue Jul 10, 2018 · 7 comments
Closed

Add dependent slots to Deliberation PSOA RuleML #78

greenTara opened this issue Jul 10, 2018 · 7 comments

Comments

@greenTara
Copy link
Member

greenTara commented Jul 10, 2018

Starting from Deliberation PSOA 1.03, the element
<slotdep>
will be added.
It can be used in Atoms like
<Atom> <oid><Ind>John</Ind></oid><op><Rel>TA</Rel></op> <slotdep><Ind>workload</Ind><Ind>high</Ind></slotdep> </Atom>

@greenTara
Copy link
Member Author

greenTara commented Jul 10, 2018

Examples will be added to test the new schema modules and illustrating the new language features. The XML files will be added to directories like exa/DatalogPSOA.

greenTara added a commit to RuleML/deliberation-ruleml that referenced this issue Jul 10, 2018
The schemas associated with this example do not yet exist.
Partial implementation of RuleML/issues-ruleml#78
@greenTara
Copy link
Member Author

greenTara commented Jul 12, 2018

Add slotdep module by duplicating the slot module.

Test using datalog_normal as the starting point (for now).
A new schema datalogPSOA_normal.rnc will be added to /relaxng.

A test suite will be added duplicating the example in exa. However, the association will refer to the local schema (datalogPSOA_normal.rnc) because the bash scripts are not yet in use.

An indep_valid_modules file will be added manually.

This step implemented by
RuleML/deliberation-ruleml@90c7c5b
RuleML/deliberation-ruleml@7cbb955

@greenTara
Copy link
Member Author

greenTara commented Jul 17, 2018

Extend the content models of <Atom> and <Expr> to include zero or more dependent slots following positional arguments and preceding independent slots. The pattern

slotsForAtoms.sequence |= slotTermsForAtoms.sequence, restOfSlots-edge.choice?

becomes

slotsForAtoms.sequence |= slotdepTermsForAtoms.sequence, slotTermsForAtoms.sequence, restOfSlots-edge.choice?

and similarly for slotsForExpr.sequence.

A test suite hornlogPSOA was added to deal with the case of dependent slots in functional expressions.

Implemented in the following commits:
RuleML/deliberation-ruleml@5178e2d
RuleML/deliberation-ruleml@be6f9db
RuleML/deliberation-ruleml@d8218fd
RuleML/deliberation-ruleml@905e295

@greenTara
Copy link
Member Author

greenTara commented Jul 17, 2018

Due to the sharing of patterns, these changes lead to changes in the content models of <Plex> and <Uniterm>. It is not clear if this is appropriate, as there is no predicate in a <Plex> for the slots to depend on. Before finalizing this issue, it should be considered to split slotsForExpressions.sequence to create a new pattern slotsForPlexes.sequence that does not allow dependent slots.

@rimachaudhari
Copy link

rimachaudhari commented Jun 4, 2019

The following commits complete the implementation (anti-chronological):
RuleML/deliberation-ruleml@994f573
RuleML/deliberation-ruleml@cddce5e
RuleML/deliberation-ruleml@50d18bb

rimachaudhari referenced this issue in RuleML/deliberation-ruleml Jun 4, 2019
convention is dependent first, independent second

Signed-off-by: greenTara <taraathan@gmail.com>
rimachaudhari referenced this issue in RuleML/deliberation-ruleml Jun 6, 2019
…nsive

Signed-off-by: greenTara <taraathan@gmail.com>
rimachaudhari referenced this issue in RuleML/deliberation-ruleml Jun 6, 2019
…r testing

Signed-off-by: greenTara <taraathan@gmail.com>
rimachaudhari referenced this issue in RuleML/deliberation-ruleml Jun 6, 2019
rimachaudhari referenced this issue in RuleML/deliberation-ruleml Jun 6, 2019
rimachaudhari referenced this issue in RuleML/deliberation-ruleml Jun 6, 2019
rimachaudhari referenced this issue in RuleML/deliberation-ruleml Jun 6, 2019
Also add copy statements to batch_config2rnc4simp
rimachaudhari referenced this issue in RuleML/deliberation-ruleml Jun 6, 2019
rimachaudhari referenced this issue in RuleML/deliberation-ruleml Jun 6, 2019
rimachaudhari referenced this issue in RuleML/deliberation-ruleml Jun 6, 2019
rimachaudhari referenced this issue in RuleML/deliberation-ruleml Jun 6, 2019
rimachaudhari referenced this issue in RuleML/deliberation-ruleml Jun 6, 2019
rimachaudhari referenced this issue in RuleML/deliberation-ruleml Jun 6, 2019
Also simplified conclusion, makeing use of the oidless form of dependent slots.
rimachaudhari referenced this issue in RuleML/deliberation-ruleml Jun 6, 2019
rimachaudhari referenced this issue in RuleML/deliberation-ruleml Jun 6, 2019
rimachaudhari referenced this issue in RuleML/deliberation-ruleml Jun 6, 2019
rimachaudhari referenced this issue in RuleML/deliberation-ruleml Jun 17, 2019
Bash scripts were modified in the previous commit.
Also a php problem with timezone was fixed.
rimachaudhari referenced this issue in RuleML/deliberation-ruleml Jun 17, 2019
We changed manually-written RNC drivers to PHP-generated RNC drivers.
Also naffologeqPSOA drivers generated.
rimachaudhari referenced this issue in RuleML/deliberation-ruleml Jun 17, 2019
Partial implementation.
@greenTara
Copy link
Member Author

greenTara commented Jun 25, 2019

In normalizer_module.xslt, change all occurrences of

          local-name(.)!='repo' and 
          local-name(.)!='slot' and

to

          local-name(.)!='repo' and 
          local-name(.)!='slotdep' and
          local-name(.)!='slot' and

Also

  <xsl:apply-templates select="ruleml:repo" mode="phase-2"/>
  <xsl:apply-templates select="ruleml:slot" mode="phase-2"/>

to

  <xsl:apply-templates select="ruleml:repo" mode="phase-2"/>
  <xsl:apply-templates select="ruleml:slotdep" mode="phase-2"/>
  <xsl:apply-templates select="ruleml:slot" mode="phase-2"/>

and similarly for other occurrences of slot.

greenTara referenced this issue in RuleML/deliberation-ruleml Jul 2, 2019
@tmitsi tmitsi changed the title Add PSOA dependent slots to Deliberation Add dependent slots to Deliberation PSOA RuleML Feb 28, 2020
@tmitsi tmitsi closed this as completed Feb 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants