Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add basic OAuth implementation #3

Merged
merged 1 commit into from Jan 2, 2019

Conversation

FranciscoDA
Copy link
Contributor

This adds some basic support for OAuth authorization (#2)
Also fixes a strange bug where retweeters' ids weren't being stringified

Btw: I accidentally messed up the indentation so I reindented the whole file, sorry :/

@Rumpelcita
Copy link
Owner

Hi, why did you close this? Was it because of the indentation?

@FranciscoDA FranciscoDA reopened this Dec 30, 2018
@FranciscoDA
Copy link
Contributor Author

@Rumpelcita Sorry, I thought it wouldn't get merged. I've just reopened it 👍

@Rumpelcita Rumpelcita merged commit 05e9f2c into Rumpelcita:master Jan 2, 2019
@Rumpelcita
Copy link
Owner

Hey, I merged this, but when I tested it on glitch, I get the following error:

{"statusCode":401,"data":"{"errors":[{"code":32,"message":"Could not authenticate you."}]}"}

So I'm reverting the changes.

@FranciscoDA
Copy link
Contributor Author

That's odd. Maybe it's something in the app's configuration in Twitter's developer panel? It makes sense that Twitter will refuse to give a request token if the consumer key, consumer secret or callback url are incorrect, but wouldn't an HTTP 403 status be more appropiate?

Here's my current config:
my app config

@Rumpelcita
Copy link
Owner

Okay, it seems the issue was that server.js wasn't using glitch's credentials. I fixed it, so now everything is working as it should and I added the reporting option.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants