Skip to content

Commit

Permalink
Update Manual UI QA checklist (#1373)
Browse files Browse the repository at this point in the history
Co-authored-by: Eunice Chan <eunice@aqueducthq.com>
  • Loading branch information
eunice-chan and eunice-chan committed May 26, 2023
1 parent cf1d495 commit ec436d9
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 12 deletions.
10 changes: 5 additions & 5 deletions manual_qa_tests/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -23,12 +23,12 @@ To run with more flexibility, configure the following commandline flags:
* There should be **9** workflows. **4** Succeeded, **2** Warning, **2** Failed, and **1** Registered if **not** using `-example-notebooks`
* **Notifications**: There should be **2** notifications for failed workflow.
* **Workflow Details** Page: Each page should reflect the **workflow description**. Pay attention to any noted **sidesheets** behaviors in the description.
* **Integration** Page:
* There should be **1** *Cloud* integration, **11** *Data* integrations, **6** *Compute* integrations, and **2** *Notifications* integrations.
* If you are not using additional integration, `Demo` should be the only available one. If you have passed in slack arguments to `initialize.py`, there should be two.
* **Integration Details** Page:
* **Resource** Page:
* There should be **1** *Container Registry* integration, **11** *Data* integrations, **6** *Compute* integrations, and **2** *Notifications* integrations.
* If you are not using additional integration, `Demo`, `Aqueduct Server`, and `Filesystem` should be the only available ones. If you have passed in slack arguments to `initialize.py`, there should be four (`test_slack_notification`).
* **Resource Details** Page:
* In the **Workflows** section of the `Demo` page:
* There should be **13** workflows if using `--example-notebooks`
* There should be **12** workflows if using `--example-notebooks`
* There should be **7** workflows if **not** using `--example-notebooks`
* If you are using `Demo`, there should be **8** tables in **Data** section.
* **Data** Page: There should be **7** data rows available.
Expand Down
6 changes: 0 additions & 6 deletions manual_qa_tests/workflows/check_status_test.py
Original file line number Diff line number Diff line change
Expand Up @@ -8,12 +8,6 @@
* warning_level_fail which shows warning icon.
* error_level_pass which shows success icon.
* Workflow Details Page:
* Error message should appear below workflow header:
A workflow-level error occurred!
Error executing workflow
Operator execution failed due to user error.
<stack trace>
* Two DAGs should appear - one for success and one for failure cases.
* Success Test Dag:
- test_pass operator (succeeded) -> test_pass_artifact (created) -> warning_level_pass (passed)
Expand Down
2 changes: 1 addition & 1 deletion manual_qa_tests/workflows/succeed_complex.py
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
NAME = "succeed_complex"
DESCRIPTION = """* Workflows Page: should succeed.
* Workflow Details Page: everything should be green.
* Data Page: pred_churn artifact should appears."""
* Data Page: pred_ensemble artifact should appears."""


@aq.op(requirements=["numpy"])
Expand Down

0 comments on commit ec436d9

Please sign in to comment.