Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement RTK mutations for workflow trigger / edit endpoints #1332

Conversation

likawind
Copy link
Contributor

Describe your changes and why you are making these changes

This PR implements RTK mutations for workflow trigger / edit. We didn't migrate route names to ideal state (use PATCH and POST method on workflow/<id> route), which requries further refactor of handler interface. The current implementation allows us to easilily change frontend code (just a route name and method change) when we migrate to ideal state in future.

Related issue number (if any)

Loom demo (if any)

Checklist before requesting a review

  • I have created a descriptive PR title. The PR title should complete the sentence "This PR...".
  • I have performed a self-review of my code.
  • I have included a small demo of the changes. For the UI, this would be a screenshot or a Loom video.
  • If this is a new feature, I have added unit tests and integration tests.
  • I have run the integration tests locally and they are passing.
  • I have run the linter script locally (See python3 scripts/run_linters.py -h for usage).
  • All features on the UI continue to work correctly.
  • Added one of the following CI labels:
    • run_integration_test: Runs integration tests
    • skip_integration_test: Skips integration tests (Should be used when changes are ONLY documentation/UI)

@likawind likawind merged commit ad3b740 into eng-2847-m1-implement-wfiddags-endpoint-with May 18, 2023
11 checks passed
@likawind likawind deleted the eng-2712-m1-migrate-wf-edit-trigger-endpoints-to branch May 22, 2023 23:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants