Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENG 3042 Use checks status in workflow status #1376

Conversation

eunice-chan
Copy link
Contributor

Describe your changes and why you are making these changes

Use checks status as part of the workflow status.

Related issue number (if any)

ENG 3042

Loom demo (if any)

Succeed with warning
Screen Shot 2023-05-25 at 10 33 02 AM
Failed due to check
Screen Shot 2023-05-25 at 11 19 09 AM

Checklist before requesting a review

  • I have created a descriptive PR title. The PR title should complete the sentence "This PR...".
  • I have performed a self-review of my code.
  • I have included a small demo of the changes. For the UI, this would be a screenshot or a Loom video.
  • [N/A] If this is a new feature, I have added unit tests and integration tests.
  • [N/A] I have run the integration tests locally and they are passing.
  • I have run the linter script locally (See python3 scripts/run_linters.py -h for usage).
  • All features on the UI continue to work correctly.
  • Added one of the following CI labels:
    • run_integration_test: Runs integration tests
    • skip_integration_test: Skips integration tests (Should be used when changes are ONLY documentation/UI)

@eunice-chan eunice-chan added the skip_integration_test Skips required integration test (only documentation/UI changes) label May 25, 2023
@eunice-chan eunice-chan requested a review from likawind May 25, 2023 18:22
Copy link
Contributor

@likawind likawind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do notice some edge case where the fix may not work, and have some suggestions on better organizing the code. I'd let you decide if code reorg could come separately as they may be easier when combining with #1374 , but do consider them as immediate follow-ups if you decide not to do them in these two PRs

src/ui/common/src/components/pages/workflows/index.tsx Outdated Show resolved Hide resolved
@eunice-chan
Copy link
Contributor Author

Workflow statuses look good for all manual QA test flows.

image image image

@eunice-chan eunice-chan requested a review from likawind May 31, 2023 05:11
Copy link
Contributor

@likawind likawind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, just one minor comment!

src/ui/common/src/components/pages/workflows/index.tsx Outdated Show resolved Hide resolved
Eunice Chan added 2 commits June 2, 2023 09:29
@eunice-chan eunice-chan merged commit 28cccc8 into main Jun 2, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip_integration_test Skips required integration test (only documentation/UI changes)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants