Rebase code with latest main after the refactor and implement UI for ondemand GKE #1384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
likawind
reviewed
May 30, 2023
| @@ -283,9 +299,94 @@ const OnDemandK8sAWSStep: React.FC<ResourceDialogProps> = ({ | |||
| ); | |||
| }; | |||
|
|
|||
| const OnDemandK8sGCPStep: React.FC<ResourceDialogProps> = ({ | |||
likawind
reviewed
May 30, 2023
| interface OnDemandK8sStepProps extends ResourceDialogProps { | ||
| handlePrevious: () => void; | ||
| handleAWSClick: () => void; | ||
| handleGCPClick: () => void; |
There was a problem hiding this comment.
We've changed this to onSelectProvider so we shouldn't need to add an extra handler here
likawind
reviewed
May 30, 2023
| service_account_key: '', | ||
| }; | ||
|
|
||
| export const GCPDialog: React.FC<ResourceDialogProps> = () => { |
There was a problem hiding this comment.
similarly, update with changes in #1380 and follow a few pattern updates. The main necessary thing is to add a type to ResourceDialogProps here
likawind
reviewed
May 30, 2023
jpurusho65
approved these changes
May 31, 2023
cw75
added
skip_integration_test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes and why you are making these changes
This PR rebases @jpurusho65 's PR against
main, fixes a few bugs and also implements registering ondemand GKE from the UI.Related issue number (if any)
Loom demo (if any)
Checklist before requesting a review
python3 scripts/run_linters.py -hfor usage).run_integration_test: Runs integration testsskip_integration_test: Skips integration tests (Should be used when changes are ONLY documentation/UI)