Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENG-3095: Fixes console warning related to @parcel-resolver/buffer #1406

Merged
merged 1 commit into from Jun 6, 2023

Conversation

agiron123
Copy link
Contributor

@agiron123 agiron123 commented Jun 3, 2023

Describe your changes and why you are making these changes

This PR fixes a warning in the ui/app build related to a mismatch in the version of the "buffer package"

Warning:

@parcel/resolver-default: Could not find module "buffer" satisfying ^5.5.0.

  /home/runner/work/aqueduct/aqueduct/src/ui/app/package.json:48:5
    47 |     "@typescript-eslint/parser": "5.59.5",
  > 48 |     "buffer": "6.0.3",
  >    |     ^^^^^^^^ Found this conflicting local requirement.
    49 |     "eslint": "8.40.0",
    50 |     "eslint-config-prettier": "8.8.0",

Related issue number (if any)

ENg-3095

Loom demo (if any)

https://www.loom.com/share/5bdb49ac937c4f8ab641759ef18be6c7

Checklist before requesting a review

  • I have created a descriptive PR title. The PR title should complete the sentence "This PR...".
  • I have performed a self-review of my code.
  • I have included a small demo of the changes. For the UI, this would be a screenshot or a Loom video.
  • If this is a new feature, I have added unit tests and integration tests.
  • I have run the integration tests locally and they are passing.
  • I have run the linter script locally (See python3 scripts/run_linters.py -h for usage).
  • All features on the UI continue to work correctly.
  • Added one of the following CI labels:
    • run_integration_test: Runs integration tests
    • skip_integration_test: Skips integration tests (Should be used when changes are ONLY documentation/UI)

@agiron123 agiron123 mentioned this pull request Jun 5, 2023
8 tasks
@agiron123 agiron123 added the skip_integration_test Skips required integration test (only documentation/UI changes) label Jun 5, 2023
@agiron123 agiron123 requested a review from likawind June 6, 2023 00:02
@agiron123 agiron123 force-pushed the eng-3095-fix-buffer-warning-on-frontend-build branch from 18d6188 to 3f885ba Compare June 6, 2023 00:03
@agiron123
Copy link
Contributor Author

@likawind latest loom demo can be found here:
https://www.loom.com/share/5bdb49ac937c4f8ab641759ef18be6c7

@agiron123 agiron123 merged commit 740261a into main Jun 6, 2023
5 checks passed
@agiron123 agiron123 deleted the eng-3095-fix-buffer-warning-on-frontend-build branch June 6, 2023 00:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip_integration_test Skips required integration test (only documentation/UI changes)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants