Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v5.2.0 #1264

Merged
merged 43 commits into from
Mar 26, 2024
Merged

v5.2.0 #1264

merged 43 commits into from
Mar 26, 2024

Conversation

TheTrunk
Copy link
Member

@TheTrunk TheTrunk commented Mar 26, 2024

  • UI improvements;
  • Test Suite improvements;
  • Other small improvements;

Copy link

gitguardian bot commented Mar 26, 2024

⚠️ GitGuardian has uncovered 2 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
10071586 Triggered Generic High Entropy Secret 756714f tests/unit/fluxCommunicationMessagesSender.test.js View secret
10071586 Triggered Generic High Entropy Secret 7c6a931 tests/unit/fluxCommunicationMessagesSender.test.js View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

Copy link

codecov bot commented Mar 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 47.52%. Comparing base (9a375d9) to head (f94fe94).
Report is 24 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1264      +/-   ##
==========================================
+ Coverage   47.25%   47.52%   +0.27%     
==========================================
  Files          45       47       +2     
  Lines       15339    15420      +81     
==========================================
+ Hits         7249     7329      +80     
- Misses       8090     8091       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@Cabecinha84 Cabecinha84 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ack

if (syncthingVersion.status === 'error') {
throw syncthingVersion.data;
}
info.flux.syncthingVersion = syncthingVersion.data.version;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is causing tests to fail as the syncthing dir hasn't been updated and getting EACCESS. Probably needs to be stubbed

@TheTrunk TheTrunk merged commit cab73f6 into master Mar 26, 2024
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants