-
Notifications
You must be signed in to change notification settings - Fork 299
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v5.2.0 #1264
v5.2.0 #1264
Conversation
TheTrunk
commented
Mar 26, 2024
•
edited by Cabecinha84
edited by Cabecinha84
- UI improvements;
- Test Suite improvements;
- Other small improvements;
…, added custom buttons in form-wizard footer
…test_environment Add testing information
…_runner The shell command abstraction pull
|
GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
---|---|---|---|---|---|
10071586 | Triggered | Generic High Entropy Secret | 756714f | tests/unit/fluxCommunicationMessagesSender.test.js | View secret |
10071586 | Triggered | Generic High Entropy Secret | 7c6a931 | tests/unit/fluxCommunicationMessagesSender.test.js | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secrets safely. Learn here the best practices.
- Revoke and rotate these secrets.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
Our GitHub checks need improvements? Share your feedbacks!
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1264 +/- ##
==========================================
+ Coverage 47.25% 47.52% +0.27%
==========================================
Files 45 47 +2
Lines 15339 15420 +81
==========================================
+ Hits 7249 7329 +80
- Misses 8090 8091 +1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ack
if (syncthingVersion.status === 'error') { | ||
throw syncthingVersion.data; | ||
} | ||
info.flux.syncthingVersion = syncthingVersion.data.version; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is causing tests to fail as the syncthing dir hasn't been updated and getting EACCESS. Probably needs to be stubbed