-
Notifications
You must be signed in to change notification settings - Fork 297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fluxService - update shell commands and refactor #1271
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## development #1271 +/- ##
===============================================
- Coverage 47.44% 47.34% -0.11%
===============================================
Files 47 47
Lines 15446 15444 -2
===============================================
- Hits 7329 7312 -17
- Misses 8117 8132 +15 ☔ View full report in Codecov by Sentry. |
I forgot to make the helpers executable on this branch... have done so now. Have also tested this on nodeJS 14.21.3 on a live node... working. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ack
What this pull does
To Do
I'd like to revisit this again in the future and tidy up some of the path stuff, i.e. can just use
process.cwd()
for a lot of the directory stuff. Look at refactoring some of the methods, as a lot of them are quite similar and could probably remove a lot of lines of code here. Shame commonJS doesn't have decorators, as this would be a perfect place to use them.