Docker command migration #1281
Merged
Docker command migration #1281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
All tests passing now
|
Cabecinha84
reviewed
Apr 26, 2024
| // this always has length | ||
| if (lines.slice(-1)[0] === '') lines.pop(); | ||
|
|
||
| lines.forEach((line) => log.info(line)); |
There was a problem hiding this comment.
Shouldn't all this continue inside a try catch?
There was a problem hiding this comment.
Yeah nice spot, the stdout.split() could throw, I'll fix.
There was a problem hiding this comment.
This highlighted an error I had in runCommand, stdout and stderr as allways returned as strings from child_process execFile. I've fixed this up (and tests). Now the above code will never throw. Howver, for safety, have wrapped in a try / catch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this pull does
*. Uses the more modern
findmntinstead of mount*. Added a bunch of notes so in 6 months time I remember how things work.
*. Removes the df command - not needed anymore with findmnt.
*. Log output if the module is run via node directly.
@XK4MiLX - Can you please check the deviceHelper stuff, I'm pretty sure this is correct but want to make certain.
I haven't run this on any nodes yet - will do that this afternoon.