v5.6.0 #1286
Merged
v5.6.0 #1286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Cabecinha84
commented
Apr 30, 2024
Cabecinha84
commented
- Improvements on updates applications without extending subscriptions;
- Disable syncthing conflicts files;
- Better handling with apt, all installs/updates are now handled by System Service.
- Other small improvements.
* Add fifo queue, udpate systemService * Make apt / cmd install more robust * Add tests for fifo queue, add a few bugfixes / features * Add dpkg version tests * Update systemService tests and bugfixes * Lint * Fix up serviceHelper tests (addition of runCmd timeout) * Move syncthing install from bash script to systemService * Lint / bugfix * Fix existing tests * Patch for node 14 fs constants * Fix typo in version check command * Add tests for adding apt sources * Lint * Patch dpkg check to make sure package actually installed * Move eslint rule to correct line * Remove test runner from serviceHelper
Cabecinha84
requested review from
alihm,
MorningLightMountain713,
JKTUNING,
TheTrunk and
XK4MiLX
|
| GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
|---|---|---|---|---|---|
| 8398280 | Triggered | PGP Private Key | 6c83e9c | HomeUI/dist/js/index.js | View secret |
| 8398280 | Triggered | PGP Private Key | 6c83e9c | HomeUI/dist/js/index.js | View secret |
| 8398280 | Triggered | PGP Private Key | 3db08c6 | HomeUI/dist/js/index.js | View secret |
| 8398280 | Triggered | PGP Private Key | 3db08c6 | HomeUI/dist/js/index.js | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secrets safely. Learn here the best practices.
- Revoke and rotate these secrets.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
Our GitHub checks need improvements? Share your feedbacks!
TheTrunk
approved these changes
Apr 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.