added release script for updating users #135
Conversation
Hey @mjhea0, We should make sure that the config file section matches something like this as commands in the bridge area wouldn't have access to the
|
in the release script? |
It's already setup that way |
Right but the other scripts should use that same setup. The ones in |
Okay. Do you want the config files updated in the bridge config files as well?
|
The bridge config should already have those values though they may be named something different. |
Do you want me to squash some of these commits? |
Combine them into this one PR? Yeah, it can be multiple bounties though. |
I'd rather leave them separate, but if it's easier, I can combine them. The bounties are split up already. |
Er I get what you mean now, kill the commits. Sorry operating on little sleep today :) |
Same here. :) Anyway, if the commits make sense, go ahead with the merges. If not, then I can squash them into a single commit for each pull. Your call. |
host = app.config['DBHOST'] | ||
database = app.config['DATABASE'] | ||
auth_key = app.config['DBAUTHKEY'] | ||
conn = r.connect(host, 28015, auth_key=auth_key).repl() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should make sure that this is following the yml config since we are putting it into the mgmtscripts
directory. Basically it would be loaded via a bridge
docker instance.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yup. I updated this already. It actually hits the other PR -> #133
Sorry. I know it's confusing. Merge this one first and then 133 and it will work. This PR should really just be for the release script while 133 hits the mgmt scripts.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it help if I close both PRs - 133 and 135 - and then just lump it all into one PR (both the releasescript and updated mgmt files)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So depending on how you did these.
If #135 was coded and commited first and then later you created the code in #133 github should be able to auto merge if i merge this first then #133.
But if you didn't when I merge this #133 won't be able to automerge and we would have to go in and make it merge worthy.
No description provided.