Skip to content
This repository has been archived by the owner on Nov 26, 2017. It is now read-only.

added release script for updating users #135

Closed
wants to merge 3 commits into from
Closed

added release script for updating users #135

wants to merge 3 commits into from

Conversation

mjhea0
Copy link
Contributor

@mjhea0 mjhea0 commented Dec 19, 2014

No description provided.

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling 611299d on mjhea0:releasescript into 3bb409d on asm-products:develop.

@madflojo
Copy link
Contributor

Hey @mjhea0,

We should make sure that the config file section matches something like this as commands in the bridge area wouldn't have access to the web.cfg.

if len(sys.argv) != 2:
    print("Hey, thats not how you launch this...")
    print("%s <config file>") % sys.argv[0]
    sys.exit(1)

# Open Config File and Parse Config Data
configfile = sys.argv[1]
cfh = open(configfile, "r")
config = yaml.safe_load(cfh)
cfh.close()

@mjhea0
Copy link
Contributor Author

mjhea0 commented Dec 20, 2014

in the release script?

@mjhea0
Copy link
Contributor Author

mjhea0 commented Dec 20, 2014

It's already setup that way

@madflojo
Copy link
Contributor

Right but the other scripts should use that same setup. The ones in mgmtscripts.

@mjhea0
Copy link
Contributor Author

mjhea0 commented Dec 20, 2014

Okay. Do you want the config files updated in the bridge config files as well?

DBHOST = "foo"
DBPORT = "bar"
DATABASE = "foo"
DBAUTHKEY = "bar"

@madflojo
Copy link
Contributor

The bridge config should already have those values though they may be named something different.

@mjhea0
Copy link
Contributor Author

mjhea0 commented Dec 20, 2014

#133

Do you want me to squash some of these commits?

@madflojo
Copy link
Contributor

Combine them into this one PR? Yeah, it can be multiple bounties though.

@mjhea0
Copy link
Contributor Author

mjhea0 commented Dec 20, 2014

I'd rather leave them separate, but if it's easier, I can combine them. The bounties are split up already.

@madflojo
Copy link
Contributor

Er I get what you mean now, kill the commits. Sorry operating on little sleep today :)

@mjhea0
Copy link
Contributor Author

mjhea0 commented Dec 20, 2014

Same here. :)

Anyway, if the commits make sense, go ahead with the merges. If not, then I can squash them into a single commit for each pull. Your call.

host = app.config['DBHOST']
database = app.config['DATABASE']
auth_key = app.config['DBAUTHKEY']
conn = r.connect(host, 28015, auth_key=auth_key).repl()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should make sure that this is following the yml config since we are putting it into the mgmtscripts directory. Basically it would be loaded via a bridge docker instance.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh you know what, I see in #133 that you have it modified to use the yml config. Maybe just squash this file from the PR and then it will get merged with #133.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup. I updated this already. It actually hits the other PR -> #133

Sorry. I know it's confusing. Merge this one first and then 133 and it will work. This PR should really just be for the release script while 133 hits the mgmt scripts.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it help if I close both PRs - 133 and 135 - and then just lump it all into one PR (both the releasescript and updated mgmt files)?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So depending on how you did these.

If #135 was coded and commited first and then later you created the code in #133 github should be able to auto merge if i merge this first then #133.

But if you didn't when I merge this #133 won't be able to automerge and we would have to go in and make it merge worthy.

@mjhea0 mjhea0 closed this Dec 20, 2014
@mjhea0 mjhea0 deleted the releasescript branch December 20, 2014 19:15
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants