This repository has been archived by the owner on Jun 7, 2023. It is now read-only.
Refactor Component API #1099
Merged
Refactor Component API #1099
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…estoneComponents into save_current
refactoring continue to provide a standard interface all components.
Mostly work on the new API for components and testing them in and out of exam mode.
* **Success** the component_factory is now consistent for all except selectquestions
Big refactoring of the grade function. Took out all of the feedback code and moved it to render feedback.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR accomplishes several big goals, that were all intertwined.
All (gradable) components now support the API as defined in Consistent Component API #1087
All gradable components now provide the server with a percentage. This means any component could be graded on percent correct.
The timed exam code is much more modular and resilient. There should be no more spuriously logged incorrect answers etc. When
selectquestionis used the questions are not selected until the student navigates to the question for the first time which eliminates any possibility of duplicate questions.General listing and cleanup. More of this could still be done.