Better Master Process Exit Handling #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 10, 2015 12:39
* The `beforeExit` callback is always executed before the master process exits for any reason. * Master process now explicitly exits if all the workers have died.
|
I am not sure why that |
| * @param {Error} [err] Error that caused the master process to exit. | ||
| */ | ||
| ClusterManager.prototype._exitMaster = function (err) { | ||
| this.options.beforeExit(err); |
There was a problem hiding this comment.
should this take a cb? otherwise we might exit if the beforeExit function is async
There was a problem hiding this comment.
That's a good point, on it!
|
that |
rsandor
added a commit
that referenced
this pull request
Apr 17, 2015
Better Master Process Exit Handling
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new option named
beforeExitto theClusterManagerconstructor. This method will be executed before the master process is forcibly exited. Additionally, the manager will automatically exit if all of the worker processes die.