ES6 #5
Merged
ES6 #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| .then((_) => { | ||
| let promises = [] | ||
|
|
||
| const shuffle = knuth_shuffle.knuthShuffle |
There was a problem hiding this comment.
| * @return {Object} Cleaned (if applicable) value. | ||
| */ | ||
| clean_value (value) { | ||
| debug('clean_value') |
There was a problem hiding this comment.
would you want to put the value in the debug statement?
There was a problem hiding this comment.
not really... the reason I have all those debug statements was to track the flow of things for a while. they can be expanded in the future, but not interested in doing that now
the test delays for 5, but sometimes CI runs fast enough (and locally) that the delay is exactly 5 as well. let's just bring it down a har
|
+1 look cool |
bkendall
added a commit
that referenced
this pull request
Feb 29, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rewrote the module in ES6. When published, it builds the source to a common js module so it is still usable by
0.10.