Expose patched method/function name in aspects API #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -85,7 +85,7 @@ exports.aroundCallback = function(args, hookBefore, hookAfter) { | |||
| var ret = orig.apply(this, arguments); | |||
|
|
|||
| if(hookAfter) { | |||
| hookAfter(this, arguments); | |||
| hookAfter(this, arguments, ret); | |||
There was a problem hiding this comment.
@seabaylea Is this change another fix? It doesn't look related to the method name change, unless I'm missing something?
|
Yeah, its a "small fix" which didn't look like it really deserved its own issue... hookAfter should have three parameters: this, arguments and return value. For some reason that call was missing the return value. |
|
OK, LGTM then. Are you ready for it to be merged? |
|
Yup - it should be good to go. |
tunniclm
added a commit
that referenced
this pull request
Nov 10, 2015
Expose patched method/function name in aspects API
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This provides the "methodName" that's been patched to the function callbacks to the aspects.before(), aspects.after() and aspects.around() calls so that its possible to know which function is being patched if an array of function names was provided.
Its passed as the new last parameter to avoid affecting existing code that uses the aspects calls.