Open with Visual Studio Version 17.5.3 #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update Packages and Update Projects
Same build directory with build-gui-win-x64.cmd
fix below warnings ``` /home/takano32/GitHub/PSXPackager/PSXPackagerGUI/Pages/SinglePage.xaml.cs(324,24): warning CS0219: The variable 'format' is assigned but its value is never used [/home/takano32/GitHub/PSXPackager/PSXPackagerGUI/PSXPackagerGUI_sd2buahs_wpftmp.csproj] /home/takano32/GitHub/PSXPackager/PSXPackagerGUI/Pages/SinglePage.xaml.cs(379,22): warning CS0169: The field 'SinglePage._total' is never used [/home/takano32/GitHub/PSXPackager/PSXPackagerGUI/PSXPackagerGUI_sd2buahs_wpftmp.csproj] /home/takano32/GitHub/PSXPackager/PSXPackagerGUI/Pages/SinglePage.xaml.cs(324,24): warning CS0219: The variable 'format' is assigned but its value is never used [/home/takano32/GitHub/PSXPackager/PSXPackagerGUI/PSXPackagerGUI.csproj] /home/takano32/GitHub/PSXPackager/PSXPackagerGUI/Pages/SinglePage.xaml.cs(379,22): warning CS0169: The field 'SinglePage._total' is never used [/home/takano32/GitHub/PSXPackager/PSXPackagerGUI/PSXPackagerGUI.csproj] ```
|
Oops, sorry accidentally marked as ready for review |
Git on Bash in Windows doesn't work well `/p` command line argument. ref. https://stackoverflow.com/questions/3779701
|
@RupertAvery No, don't worry about it. Sorry it took me a little while to get back to you. I was able to run make in Git Bash(on Windows) to create a binary and confirm that it works. I installed GNU make on Windows with Invoking This is now ready for review, actually. Thanks always. |
Using SEVENZIP Package Update
```
ItemGroup Condition="$(DefineConstants.Contains('SEVENZIP'))"
```
takano32
force-pushed
the
Open-with-Visual-Studio-Version-17.5.3
branch
from
89f33ac
to
4b2fe6d
Compare
Add `msbuild.yml` and `dotnet.yml` Files for `MSBuild` and `.NET` GitHub Actions
see also. .NET 7 Self-Contained, NativeAOT, and ReadyToRun Cheatsheet https://www.nikouusitalo.com/blog/net-7-self-contained-nativeaot-and-readytorun-cheatsheet/
|
I included #37 in this PR. It may be difficult to review with large differences. Sorry. |
This was referenced Apr 13, 2023
Linux distributions running on Arm like Raspbian on Raspberry Pi Model 2+
Linux distributions running on 64-bit Arm like Ubuntu Server 64-bit on Raspberry Pi Model 3+
This was referenced Apr 13, 2023
Set InvariantGlobalization false Set IncludeNativeLibrariesForSelfExtract false
|
I confirmed https://github.com/takano32/PSXPackager/actions/runs/4688277339 LGTM! 🙇 |
RupertAvery
approved these changes
Apr 14, 2023
|
Thank you for merging! And GitHub Actions started generating binaries in this Repo! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update Packages and Update Projects
I’ll make this Ready for review after simple test in Linux and macOS.
closes #37