Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added timer #1

Merged
merged 2 commits into from
May 25, 2020
Merged

added timer #1

merged 2 commits into from
May 25, 2020

Conversation

mkassa
Copy link

@mkassa mkassa commented May 24, 2020

added countdown timer since the last time a blind has been raised.

RusselRillema
RusselRillema requested changes May 25, 2020
View reviewed changes
Copy link
Owner

@RusselRillema RusselRillema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey Mike
Please remove the package-lock.json
We have the package.json file, we don't need the -lock. Maybe we should have a gitignore file for this?
Please also add the timer to the bigger tables. You've only added it to the 2 handed table.

RusselRillema
RusselRillema approved these changes May 25, 2020
View reviewed changes
Copy link
Owner

@RusselRillema RusselRillema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Mike :)

@RusselRillema RusselRillema merged commit 8a6202f into RusselRillema:master May 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RusselRillema RusselRillema RusselRillema approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@mkassa @RusselRillema