Test failure on msp430-elfbare target #1713

CohenArthur · 2023-01-02T12:32:00Z

Rust related issues
=====================

 --target=msp430-elfbare
~~~~~~~~~~~~~~~~~~~~~~~~~
	/var/lib/laminar/run/gcc-msp430-elfbare/24/toolchain-build/./gcc/xgcc -B/var/lib/laminar/run/gcc-msp430-elfbare/24/toolchain-build/./gcc/  -xrust -frust-incomplete-and-experimental-compiler-do-not-use -nostdinc /dev/null -S -o /dev/null -fself-test=../../gcc/gcc/testsuite/selftests
	<built-in>: internal compiler error: Segmentation fault
	0xf2efbf crash_signal
	      ../../gcc/gcc/toplev.cc:314
	0x120c8c7 build_function_type(tree_node*, tree_node*, bool)
	      ../../gcc/gcc/tree.cc:7360
	0x120cc20 build_function_type_list(tree_node*, ...)
	      ../../gcc/gcc/tree.cc:7442
	0x120d16b build_common_builtin_nodes()
	      ../../gcc/gcc/tree.cc:9883
	0x8449b4 grs_langhook_init
	      ../../gcc/gcc/rust/rust-lang.cc:132
	0x8427b2 lang_dependent_init
	      ../../gcc/gcc/toplev.cc:1815
	0x8427b2 do_compile
	      ../../gcc/gcc/toplev.cc:2110
	Please submit a full bug report, with preprocessed source (by using -freport-bug).
	Please include the complete backtrace with any bug report.
	See [<https://gcc.gnu.org/bugs/>](https://gcc.gnu.org/bugs/) for instructions.
	make[1]: *** [../../gcc/gcc/rust/Make-lang.in:275: s-selftest-rust] Error 1

From https://gcc.gnu.org/pipermail/gcc-patches/2022-December/608802.html

The text was updated successfully, but these errors were encountered:

tschwinge · 2023-02-22T11:26:14Z

Patch posted: https://inbox.sourceware.org/gcc-patches/871qmi6iya.fsf@euler.schwinge.homeip.net "Rust: In 'type_for_mode' langhook also consider all 'int_n' modes/types".

As reported in "Rust related issues" at the end of <https://inbox.sourceware.org/gcc-patches/20221219212344.ewtuzd2jtztm77x2@lug-owl.de> "Modula-2 / Rust: Many targets failing", <Rust-GCC/gccrs#1713> "Test failure on msp430-elfbare target", for '--target=msp430-elfbar' we ICE: <built-in>: internal compiler error: Segmentation fault 0xf2efbf crash_signal ../../gcc/gcc/toplev.cc:314 0x120c8c7 build_function_type(tree_node*, tree_node*, bool) ../../gcc/gcc/tree.cc:7360 0x120cc20 build_function_type_list(tree_node*, ...) ../../gcc/gcc/tree.cc:7442 0x120d16b build_common_builtin_nodes() ../../gcc/gcc/tree.cc:9883 0x8449b4 grs_langhook_init ../../gcc/gcc/rust/rust-lang.cc:132 [...] This is due to 'tmp == NULL' for 'gcc/tree.cc:build_common_builtin_nodes': tmp = lang_hooks.types.type_for_mode (targetm.eh_return_filter_mode (), 0); ..., were 'targetm.eh_return_filter_mode' (that is, 'gcc/targhooks.cc:default_eh_return_filter_mode', via calling 'targetm.unwind_word_mode': 'gcc/config/msp430/msp430.cc:msp430_unwind_word_mode') returns 'PSImode', and 'lang_hooks.types.type_for_mode' (that is, 'gcc/rust/rust-lang.cc:grs_langhook_type_for_mode') returns 'NULL' for 'PSImode'. As, for example, discussed in <https://gcc.gnu.org/PR46805> "ICE: SIGSEGV in optab_for_tree_code (optabs.c:407) with -O -fno-tree-scev-cprop -ftree-vectorize", we have to support "random" modes/types in the 'type_for_mode' langhook. gcc/rust/ * rust-lang.cc (grs_langhook_type_for_mode): Also consider all 'int_n' modes/types.

jbglaw · 2023-02-25T22:21:17Z

Just had a successful build with upstream GCC: http://toolchain.lug-owl.de/laminar/jobs/gcc-msp430-elf/65

CohenArthur · 2023-02-27T09:57:55Z

Nice! Thanks for confirming @jbglaw :) closing this

As reported in "Rust related issues" at the end of <https://inbox.sourceware.org/gcc-patches/20221219212344.ewtuzd2jtztm77x2@lug-owl.de> "Modula-2 / Rust: Many targets failing", <Rust-GCC/gccrs#1713> "Test failure on msp430-elfbare target", for '--target=msp430-elfbar' we ICE: <built-in>: internal compiler error: Segmentation fault 0xf2efbf crash_signal ../../gcc/gcc/toplev.cc:314 0x120c8c7 build_function_type(tree_node*, tree_node*, bool) ../../gcc/gcc/tree.cc:7360 0x120cc20 build_function_type_list(tree_node*, ...) ../../gcc/gcc/tree.cc:7442 0x120d16b build_common_builtin_nodes() ../../gcc/gcc/tree.cc:9883 0x8449b4 grs_langhook_init ../../gcc/gcc/rust/rust-lang.cc:132 [...] This is due to 'tmp == NULL' for 'gcc/tree.cc:build_common_builtin_nodes': tmp = lang_hooks.types.type_for_mode (targetm.eh_return_filter_mode (), 0); ..., were 'targetm.eh_return_filter_mode' (that is, 'gcc/targhooks.cc:default_eh_return_filter_mode', via calling 'targetm.unwind_word_mode': 'gcc/config/msp430/msp430.cc:msp430_unwind_word_mode') returns 'PSImode', and 'lang_hooks.types.type_for_mode' (that is, 'gcc/rust/rust-lang.cc:grs_langhook_type_for_mode') returns 'NULL' for 'PSImode'. As, for example, discussed in <https://gcc.gnu.org/PR46805> "ICE: SIGSEGV in optab_for_tree_code (optabs.c:407) with -O -fno-tree-scev-cprop -ftree-vectorize", we have to support "random" modes/types in the 'type_for_mode' langhook. gcc/rust/ * rust-lang.cc (grs_langhook_type_for_mode): Also consider all 'int_n' modes/types.

Addresses: #1713 Fixes: #1973

Yesterday's commit 3757e8d "Merge commit '6baa95c9c5b3fea96fd22d03d961db4e4cf48d88' into HEAD [#2112]" brought in the #1713 change from GCC upstream master branch that broke the rules (via code copied verbatim from elsehwhere in GCC). gcc/rust/ * rust-lang.cc (grs_langhook_type_for_mode): Placate clang-format.

jbglaw · 2023-04-13T15:58:42Z

...and successful builds from the Rust-GCC repo also showed up.

Yesterday's commit 3757e8d "Merge commit '6baa95c9c5b3fea96fd22d03d961db4e4cf48d88' into HEAD [Rust-GCC#2112]" brought in the Rust-GCC#1713 change from GCC upstream master branch that broke the rules (via code copied verbatim from elsehwhere in GCC). gcc/rust/ * rust-lang.cc (grs_langhook_type_for_mode): Placate clang-format.

…_for_mode' Yesterday's commit 3757e8d "Merge commit '6baa95c9c5b3fea96fd22d03d961db4e4cf48d88' into HEAD [Rust-GCC#2112]" brought in the Rust-GCC#1713 change from GCC upstream master branch that broke the rules (via code copied verbatim from elsehwhere in GCC). gcc/rust/ * rust-lang.cc (grs_langhook_type_for_mode): Placate clang-format.

As reported in "Rust related issues" at the end of <https://inbox.sourceware.org/gcc-patches/20221219212344.ewtuzd2jtztm77x2@lug-owl.de> "Modula-2 / Rust: Many targets failing", <Rust-GCC/gccrs#1713> "Test failure on msp430-elfbare target", for '--target=msp430-elfbar' we ICE: <built-in>: internal compiler error: Segmentation fault 0xf2efbf crash_signal ../../gcc/gcc/toplev.cc:314 0x120c8c7 build_function_type(tree_node*, tree_node*, bool) ../../gcc/gcc/tree.cc:7360 0x120cc20 build_function_type_list(tree_node*, ...) ../../gcc/gcc/tree.cc:7442 0x120d16b build_common_builtin_nodes() ../../gcc/gcc/tree.cc:9883 0x8449b4 grs_langhook_init ../../gcc/gcc/rust/rust-lang.cc:132 [...] This is due to 'tmp == NULL' for 'gcc/tree.cc:build_common_builtin_nodes': tmp = lang_hooks.types.type_for_mode (targetm.eh_return_filter_mode (), 0); ..., were 'targetm.eh_return_filter_mode' (that is, 'gcc/targhooks.cc:default_eh_return_filter_mode', via calling 'targetm.unwind_word_mode': 'gcc/config/msp430/msp430.cc:msp430_unwind_word_mode') returns 'PSImode', and 'lang_hooks.types.type_for_mode' (that is, 'gcc/rust/rust-lang.cc:grs_langhook_type_for_mode') returns 'NULL' for 'PSImode'. As, for example, discussed in <https://gcc.gnu.org/PR46805> "ICE: SIGSEGV in optab_for_tree_code (optabs.c:407) with -O -fno-tree-scev-cprop -ftree-vectorize", we have to support "random" modes/types in the 'type_for_mode' langhook. gcc/rust/ * rust-lang.cc (grs_langhook_type_for_mode): Also consider all 'int_n' modes/types.

CohenArthur added the bug label Jan 2, 2023

CohenArthur added this to the Final upstream patches milestone Jan 2, 2023

tschwinge self-assigned this Feb 22, 2023

CohenArthur closed this as completed Feb 27, 2023

tschwinge mentioned this issue Mar 8, 2023

--target=msp430-elf{,bare}: internal compiler error: Segmentation fault during -fself-test=../../gccrs/gcc/testsuite/selftests #1973

Closed

tschwinge added a commit that referenced this issue Apr 8, 2023

Merge commit 'aee5ee35602e0098c2ae16fa2fc9c8845caf92ed' into HEAD

353f5e8

Addresses: #1713 Fixes: #1973

tschwinge mentioned this issue Apr 11, 2023

Placate clang-format, 'gcc/rust/rust-lang.cc:grs_langhook_type_for_mode' #2116

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Test failure on msp430-elfbare target #1713

Test failure on msp430-elfbare target #1713

CohenArthur commented Jan 2, 2023 •

edited

tschwinge commented Feb 22, 2023

jbglaw commented Feb 25, 2023

CohenArthur commented Feb 27, 2023

jbglaw commented Apr 13, 2023

Test failure on msp430-elfbare target #1713

Test failure on msp430-elfbare target #1713

Comments

CohenArthur commented Jan 2, 2023 • edited

tschwinge commented Feb 22, 2023

jbglaw commented Feb 25, 2023

CohenArthur commented Feb 27, 2023

jbglaw commented Apr 13, 2023

CohenArthur commented Jan 2, 2023 •

edited