Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update libgrust for upstream GCC commit 6a6d3817afa02bbcd2388c8e005da6faf88932f1 "Config,Darwin: Allow for configuring Darwin to use embedded runpath" #2714

Open
tschwinge opened this issue Oct 24, 2023 · 3 comments
Labels
upstream Issue regarding upstreaming gccrs into GCC

Comments

@tschwinge
Copy link
Member

tschwinge commented Oct 24, 2023

I suppose that once upstream GCC commit 6a6d3817afa02bbcd2388c8e005da6faf88932f1 "Config,Darwin: Allow for configuring Darwin to use embedded runpath" is merged in (I'm planning to work on that soonish), libgrust needs to be updated accordingly?

As a corollary, if libgrust is pushed into GCC upstream, it needs to be updated accordingly, too (before the git push)?

@CohenArthur
Copy link
Member

do you think that commit will be merged soon? also, interesting to see that the actual commit was authored in March 2021 :)

@CohenArthur CohenArthur added the upstream Issue regarding upstreaming gccrs into GCC label Oct 24, 2023
@tschwinge
Copy link
Member Author

@CohenArthur:

do you think that commit will be merged soon?

Sorry if what I wrote was ambiguous: I meant to say: "once upstream GCC commit [...] is merged [into GCC/Rust master branch] (I'm planning to work on that soonish)".

That GCC commit 6a6d381 "Config,Darwin: Allow for configuring Darwin to use embedded runpath" already is in GCC upstream, and therefore I presume https://inbox.sourceware.org/20231025110658.1232737-3-arthur.cohen@embecosm.com "libgrust: Add libproc_macro and build system" needs to be adjusted accordingly, in order to not break Darwin? (@iains?) Should be easy to do.

also, interesting to see that the actual commit was authored in March 2021 :)

Well, that happens... :-)

@iains
Copy link
Contributor

iains commented Oct 25, 2023

missing the change for Darwin would probably not break bootstrap - what it would do is to embed a fixed runpath (/prefix/lib) instead of @rpath/ .. but, yes, we should make the corresponding change - copying what is done elsewhere should work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
upstream Issue regarding upstreaming gccrs into GCC
Projects
None yet
Development

No branches or pull requests

3 participants