Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove macro HIR trees #69

Closed
philberty opened this issue Dec 17, 2020 · 0 comments · Fixed by #560
Closed

Remove macro HIR trees #69

philberty opened this issue Dec 17, 2020 · 0 comments · Fixed by #560
Labels
cleanup good-first-pr
Milestone
Data Structures 3...

Comments

@philberty
Copy link
Member

If macros are all expanded in the HIR, then this file should probably not exist. However, just in case they are needed, I would not remove the code here yet.

Originally posted by @SimplyTheOther in #64 (comment)
@philberty philberty added the bug label Dec 17, 2020
@philberty philberty added cleanup and removed bug labels Jan 29, 2021
@philberty philberty mentioned this issue Feb 23, 2021
Closed
@philberty philberty mentioned this issue Jul 12, 2021
Merged
@philberty philberty added this to the Data Structures 3 - Traits milestone Jul 12, 2021
bors bot added a commit that referenced this issue Jul 12, 2021
@bors
Merge #560
6d2a3d0 
560: Remove HIR MacroItem and other hir macro forward declarations r=philberty a=philberty

Remove trailing macro items from HIR

Fixes #69


Co-authored-by: Mark Wielaard <mark@klomp.org>
@bors bors bot closed this as completed in 36bd4a5 Jul 12, 2021
philberty pushed a commit that referenced this issue Jul 12, 2021
@philberty
Remove HIR MacroItem and other hir macro forward declarations
876f70e 
Almost all HIR Macro related trees were already removed by
#492

But there was still one MacroItem class left in rust-hir.h and several
(unused) forward declarations in various other hir .h files. Remove
them all.

Resolves: #69
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
cleanup good-first-pr
Projects
None yet
Milestone
Data Structures 3 - Traits
Development

Successfully merging a pull request may close this issue.

Remove HIR MacroItem and other hir macro forward declarations Rust-GCC/gccrs
1 participant
@philberty