TREE_ADDRESSABLE is not being set when required

[philberty]

I tried this code:

extern "C" {
    fn printf(s: *const i8, ...);
}

#[lang = "add_assign"]
pub trait AddAssign<Rhs = Self> {
    fn add_assign(&mut self, rhs: Rhs);
}

impl AddAssign for i32 {
    fn add_assign(&mut self, other: i32) {
        unsafe {
            let a = "add_assign\n\0";
            let b = a as *const str;
            let c = b as *const i8;

            printf(c);
        }
        *self += other
    }
}

fn main() -> i32 {
    let mut a = 1;
    a += 2;

    0
}

I expected to see this happen: The address is taken on the VAR_DECL not an implicit temporary

Instead, this happened: TREE_ADDRESSABLE is false on 'a' and is required to stop the implicit copy

void <i32 as AddAssign>::add_assign (i32 & self, const i32 other)
{
  {
    unsigned char * const & const a;
    unsigned char * const * const b;
    const i8 * const c;

    a = "add_assign\n";
    b = a;
    c = b;
    printf (c);
  }
  _1 = *self;
  _2 = other + _1;
  *self = _2;
}


i32 main ()
{
  i32 a.1;
  i32 D.86;
  i32 a;

  a = 1;
  a.1 = a; // this is wrong
  <i32 as AddAssign>::add_assign (&a.1, 2);
  D.86 = 0;
  return D.86;
}

Meta

• What version of Rust GCC were you using, git sha if possible. This was found during dev of the operator overloading branch but exists on: dcd7585