Fix match tests on 32bit systems #1228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Printing i64's on 32bit systems requires the proper format specifier this amends these testcases to 32bit integers so %i works as expected. I was able to use gdb to verify that these values are computed properly from the structure.
|
bors r+ |
CohenArthur
approved these changes
May 9, 2022
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Printing i64's on 32bit systems requires the proper format specifier
this amends these test cases to 32bit integers so %i works as expected.
I was able to use gdb to verify that these values are computed properly
from the structure on 32 bit systems.
Keeping the structures as i32 we can ignore platform-specific format
specifiers.