Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Privacy report expressions #1255

Merged
merged 1 commit into from May 19, 2022
Merged

Privacy report expressions #1255

merged 1 commit into from May 19, 2022

Conversation

CohenArthur
Copy link
Member

This adds privacy reporting to all expression types inside our HIR. It also restricts the PrivacyReporter visitor to HIR::Expressions and HIR::Stmts as a lot of the previous types did not need to be visited.

@CohenArthur CohenArthur added this to the Imports and visibility milestone May 18, 2022
@CohenArthur CohenArthur added this to In progress in Imports and Visbility via automation May 18, 2022
@CohenArthur
Copy link
Member Author

Sorry for the really large commit! It didn't make too much sense to split it as the changes are extremely similar

@CohenArthur CohenArthur mentioned this pull request May 18, 2022
Merged
philberty
philberty approved these changes May 19, 2022
View reviewed changes
Copy link
Member

@philberty philberty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

gcc/rust/privacy/rust-privacy-reporter.cc
void
PrivacyReporter::visit (HIR::TypePathSegmentFunction &segment)
{}
{
// FIXME: Do we need to do anything for this?
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We haven't done anything for these yet in general i always have to lookup the rust reference to remember what they are.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mmh interesting. I'll look into it when figuring out the last bits of type privacy reporting

Imports and Visbility automation moved this from In progress to Reviewer approved May 19, 2022
@CohenArthur
Copy link
Member Author

bors r+

@bors
Copy link
Contributor

bors bot commented May 19, 2022

Build succeeded:

@bors bors bot merged commit e9d41c4 into Rust-GCC:master May 19, 2022
Imports and Visbility automation moved this from Reviewer approved to Done May 19, 2022
@CohenArthur CohenArthur deleted the privacy-report-expressions branch May 19, 2022 10:46
bors bot added a commit that referenced this pull request May 20, 2022
@bors @CohenArthur
Merge #1258
5ad0ea3 
1258: Report privacy errors on explicit types r=CohenArthur a=CohenArthur

~~Needs #1255, so skip reviewing the first commit or wait for it to be merged~~ Done and rebased :)

Co-authored-by: Arthur Cohen <arthur.cohen@embecosm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philberty philberty philberty approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
No open projects
Imports and Visbility
  
Done
Milestone
Imports and visibility
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@CohenArthur @philberty