Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docker: Fix GCCRS_BUILD info #1300

Merged
merged 1 commit into from Jun 8, 2022

Conversation

CohenArthur
Copy link
Member

Sometimes, the GCCRS_BUILD file would end up empty. I believe this is
due to how Dockerfiles work in that there was a "race condition" between
the two RUN commands. Hopefully this should fix it.

Sometimes, the GCCRS_BUILD file would end up empty. I believe this is
due to how Dockerfiles work in that there was a "race condition" between
the two `RUN` commands. Hopefully this should fix it.
@CohenArthur CohenArthur added this to the Imports and visibility milestone Jun 8, 2022
@CohenArthur CohenArthur added this to In progress in Imports and Visbility via automation Jun 8, 2022
Copy link
Member

@philberty philberty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Imports and Visbility automation moved this from In progress to Reviewer approved Jun 8, 2022
@CohenArthur
Copy link
Member Author

bors r+

@bors
Copy link
Contributor

bors bot commented Jun 8, 2022

Build succeeded:

@bors bors bot merged commit 8f47bc3 into Rust-GCC:master Jun 8, 2022
Imports and Visbility automation moved this from Reviewer approved to Done Jun 8, 2022
@CohenArthur CohenArthur deleted the fix-dockerfile-commit branch June 9, 2022 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants