Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gccrs const folding port: continue porting potential_constant_expression_1() #1338

Conversation

abbasfaisal
Copy link
Collaborator

@abbasfaisal abbasfaisal commented Jun 25, 2022

@abbasfaisal abbasfaisal force-pushed the port-potential-const-expression-1-part-by-part branch from 95e3a0e to 0e4de7f Compare June 25, 2022 10:16
…ion_1()

Following functions are ported in this changeset:
 - maybe_constexpr_fn
 - get_nth_callarg
 - var_in_maybe_constexpr_fn
 - array_type_nelts_top
 - builtin_valid_in_constant_expr_p
 - decl_maybe_constant_var_p
 - cp_type_quals
@abbasfaisal abbasfaisal force-pushed the port-potential-const-expression-1-part-by-part branch from 0e4de7f to 2a7a058 Compare June 25, 2022 10:56
@@ -149,6 +149,13 @@
/* Nonzero if this class is "empty" in the sense of the C++ ABI. */
#define CLASSTYPE_EMPTY_P(NODE) (LANG_TYPE_CLASS_CHECK (NODE)->empty_p)

/* True if DECL is declared 'constexpr'. */
#define DECL_DECLARED_CONSTEXPR_P(DECL) \
DECL_LANG_FLAG_8 (VAR_OR_FUNCTION_DECL_CHECK (DECL))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for porting this over this is something I need to start setting up for this pass its super important

Copy link
Member

@philberty philberty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@philberty philberty added this to In progress in GSoC 2022 - Constexpr via automation Jun 29, 2022
@philberty
Copy link
Member

bors r+

@bors
Copy link
Contributor

bors bot commented Jun 29, 2022

Build succeeded:

@bors bors bot merged commit 9976c57 into Rust-GCC:master Jun 29, 2022
GSoC 2022 - Constexpr automation moved this from In progress to Done Jun 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants