Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hir/dump: simple dumping of crate attrs and adding a few todos #1378

Merged
merged 1 commit into from
Jul 27, 2022

Conversation

ndrwnaguib
Copy link
Contributor

This is draft PR to track the current implementation of the pretty dumping of HIR. @CohenArthur and I have agreed to keep it as simple as possible for now, and enhancements will be added along the way.

Copy link
Member

@CohenArthur CohenArthur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is good. I'll create issues for the TODOs so that you can fill them out with later PRs. Thanks :)

gcc/rust/hir/rust-hir-dump.cc Show resolved Hide resolved
gcc/rust/hir/rust-hir-dump.cc Show resolved Hide resolved
gcc/rust/hir/rust-hir-dump.cc Show resolved Hide resolved
gcc/rust/hir/rust-hir-dump.cc Outdated Show resolved Hide resolved
gcc/rust/hir/rust-hir-dump.cc Outdated Show resolved Hide resolved
@ndrwnaguib ndrwnaguib force-pushed the andrew/hir/add/pretty-dumping branch from 28bbede to 5556d29 Compare July 25, 2022 08:00
@ndrwnaguib ndrwnaguib marked this pull request as ready for review July 26, 2022 15:00
Copy link
Member

@CohenArthur CohenArthur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@CohenArthur
Copy link
Member

bors r+

@bors
Copy link
Contributor

bors bot commented Jul 27, 2022

Build succeeded:

@bors bors bot merged commit 50ca4b2 into master Jul 27, 2022
@philberty philberty deleted the andrew/hir/add/pretty-dumping branch August 26, 2022 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants