unsafe: check uses of static variables #1417
Conversation
This allows us to perform checks and dispatch when getting an HIR::Item* from Mappings::lookup_hir_item()
Using a mutable static or an extern static requires an unsafe function or block
There was a problem hiding this comment.
Nice work. LGTM
Something we might start to think about doing is for every error diagnostic have some kind of class for them all, so we can enforce good error messages so for example we might have:
class ErrorDiagnostics {
static void EStaticMutableUnsafe(Location) { }
}
| NodeId ref_node_id; | ||
| HirId definition_id; | ||
|
|
||
| if (!resolver.lookup_resolved_name (ast_node_id, &ref_node_id)) |
There was a problem hiding this comment.
This is good, ideally this pass should be permissive of saw_errors eventually but we need to have the safe interface for the type context to return error nodes instead of nullptr to do that properly.
Yeah, this will definitely come in handy when adding error codes as well! I'll open up an issue regarding this |
|
bors r+ |
|
Build succeeded: |
Addresses #1411
Accessing an extern static or a mut static is unsafe and requires an unsafe function or block