Add type resolution for grouped patterns #1771
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Owen Avery <powerboat9.gamer@gmail.com>
Signed-off-by: Owen Avery <powerboat9.gamer@gmail.com>
powerboat9
force-pushed
the
grouped-type
branch
from
2787bd8
to
01a07f7
Compare
philberty
approved these changes
Jan 26, 2023
There was a problem hiding this comment.
LGTM
I am starting to think once we get your stuff merged in we should look to see if we can desugar the HIR here, so instead of an HIR::GroupedPattern we literly lower the inner pattern and return that.. as this sort of feels very AST'y. But lets not do that yet.
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Feb 2, 2023
1783: Remove HIR::GroupedPattern r=philberty a=powerboat9 Signed-off-by: Owen Avery <powerboat9.gamer@gmail.com> Removes HIR::GroupedPattern and lowers AST::GroupedPattern to its inner pattern directly. Addresses #1771 (review) Co-authored-by: Owen Avery <powerboat9.gamer@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Owen Avery powerboat9.gamer@gmail.com
Adds type resolution for GroupedPattern.