derive: Add base for builtin derives and #[derive(Clone)] #2216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gcc/rust/expand/rust-derive-clone.cc
Outdated
| std::unique_ptr<Expr> | ||
| DeriveClone::clone_call (std::unique_ptr<Expr> &&to_clone) | ||
| { | ||
| // ::core::clone::Clone::clone for the fully qualified path - we don't link |
There was a problem hiding this comment.
It's $crate::clone::Clone::clone, the pretty printing from rustc prints $crate as the appropriate crate name.
CohenArthur
force-pushed
the
base-builtin-derive
branch
2 times, most recently
from
13c1948
to
e5079a7
Compare
CohenArthur
requested review from
matthewjasper,
philberty and
P-E-P
and removed request for
matthewjasper
P-E-P
approved these changes
May 26, 2023
P-E-P
reviewed
May 26, 2023
| { | ||
| auto new_item | ||
| = derive_item (item, attr, maybe_builtin->second); | ||
| // this inserts the derive *before* the item - is it a |
There was a problem hiding this comment.
rustc inserts the functions after the item
There was a problem hiding this comment.
shouldn't be an issue, but we'll see in the future if it arises. it's not too hard of a fix either way :)
CohenArthur
force-pushed
the
base-builtin-derive
branch
from
e5079a7
to
8e8c383
Compare
gcc/rust/ChangeLog: * ast/rust-ast-builder.cc: New file. * ast/rust-ast-builder.h: New file.
CohenArthur
force-pushed
the
base-builtin-derive
branch
from
8e8c383
to
7b1da01
Compare
gcc/rust/ChangeLog: * Make-lang.in: Add new object files to Makefile. * expand/rust-expand-visitor.cc (is_derive): Move function. (is_builtin): Likewise. (get_traits_to_derive): New function. (derive_item): Likewise. (ExpandVisitor::visit): Visit item/statements containers. (ExpandVisitor::visit_outer_attrs): Take a reference on the attribute instead of a copy. (ExpandVisitor::is_derive): Deleted function. (ExpandVisitor::is_builtin): Likewise. * expand/rust-expand-visitor.h (RUST_EXPAND_VISITOR_H): Add missing #ifdef guards. (is_derive): Declare function. (is_builtin): Likewise. * expand/rust-macro-builtins.cc (builtin_macro_from_string): Use new MacroBuiltin::builtins map. (make_macro_path_str): Likewise. * expand/rust-macro-builtins.h (enum class): Add builtin derive macros. * expand/rust-derive-clone.cc: New file. * expand/rust-derive-clone.h: New file. * expand/rust-derive.cc: New file. * expand/rust-derive.h: New file. * util/rust-hir-map.cc (Mappings::insert_macro_def): Fix logic for setting builtin macro transcribers. gcc/testsuite/ChangeLog: * rust/compile/macro43.rs: Fix test with new derive macros. * rust/compile/derive_macro1.rs: New test. * rust/compile/derive_macro3.rs: New test. * rust/execute/torture/derive_macro1.rs: New test. * rust/execute/torture/derive_macro3.rs: New test.
CohenArthur
force-pushed
the
base-builtin-derive
branch
from
7b1da01
to
bec74b0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds basic support for builtin derive macros and, more specifically, deriving Clone on some simple structures (tuple structs and empty structs). Keeping it as a draft as it still needs some work. Needs #2214