Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Combine {,Proc}MacroInvocLexer #2337

Closed
wants to merge 3 commits into from
Closed

Combine {,Proc}MacroInvocLexer #2337

wants to merge 3 commits into from

Conversation

powerboat9
Copy link
Contributor

Addresses/Solves #2276

@powerboat9 powerboat9 marked this pull request as draft June 27, 2023 20:50
@powerboat9 powerboat9 force-pushed the join-invoc branch 2 times, most recently from 6e020f1 to 85ac151 Compare June 30, 2023 01:44
@powerboat9
Create MacroInvocLexerBase
d8c3baa 
gcc/rust/ChangeLog:

	* expand/rust-macro-invoc-lexer.h
	(class MacroInvocLexerBase): New.

Signed-off-by: Owen Avery <powerboat9.gamer@gmail.com>
@powerboat9
Use MacroInvocLexerBase in MacroInvocLexer
4c5a947 
gcc/rust/ChangeLog:

	* expand/rust-macro-invoc-lexer.cc
	(MacroInvocLexer::skip_token): Remove.
	* expand/rust-macro-invoc-lexer.h
	(class MacroInvocLexer): Extend MacroInvocLexerBase.

Signed-off-by: Owen Avery <powerboat9.gamer@gmail.com>
@powerboat9 powerboat9 mentioned this pull request Jun 30, 2023
Merged
@powerboat9
Copy link
Contributor Author

Split off #2351

@powerboat9
Use MacroInvocLexerBase in ProcMacroInvocLexer
34abaa5 
gcc/rust/ChangeLog:

	* expand/rust-proc-macro-invoc-lexer.cc
	(ProcMacroInvocLexer::skip_token): Remove.
	* expand/rust-proc-macro-invoc-lexer.h:
	Include "rust-macro-invoc-lexer.h".
	(class ProcMacroInvocLexer):
	Extend MacroInvocLexerBase.

Signed-off-by: Owen Avery <powerboat9.gamer@gmail.com>
This was referenced Jul 31, 2023
Merged
Merged
@powerboat9
Copy link
Contributor Author

With #2497 and #2498 merged, this pull request should be complete

@powerboat9 powerboat9 closed this Aug 11, 2023
@powerboat9 powerboat9 deleted the join-invoc branch August 11, 2023 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@powerboat9