[E0571] break with argument in non-loop loop

[MahadMuhammad]

break with argument in non-loop loop - E0571

• A break statement with an argument appeared in a non-loop loop.
• Refactored error message similiar to rustc
  & called error function.

---

Code Tested from E0571

// https://doc.rust-lang.org/error_codes/E0571.html
#![allow(unused)]
fn main() {
    let mut i = 1;
    fn satisfied(n: usize) -> bool {
        n % 23 == 0
    }
    let result = while true {
        if satisfied(i) {
            break 2 * i;  // { dg-error ".break. with value from a .while. loop" }
        }
        i += 1;
    };
}

---

Output:

/home/mahad/Desktop/mahad/gccrs/gcc/testsuite/rust/compile/break_with_value_inside_loop.rs:10:13: error: 'break' with value from a 'while' loop [E0571]
compiler exited with status 1
PASS: rust/compile/break_with_value_inside_loop.rs  (test for errors, line 10)
PASS: rust/compile/break_with_value_inside_loop.rs (test for excess errors)

---

Running testcases:

• gcc/testsuite/rust/compile/break2.rs

/home/mahad/Desktop/mahad/gccrs/gcc/testsuite/rust/compile/break2.rs:8:13: error: 'break' with value from a 'while' loop [E0571]
compiler exited with status 1
PASS: rust/compile/break2.rs  (test for errors, line 8)
PASS: rust/compile/break2.rs (test for excess errors)

---

gcc/rust/ChangeLog:

* typecheck/rust-hir-type-check-expr.cc (TypeCheckExpr::visit): refactored error message & called error function.

gcc/testsuite/ChangeLog:

* rust/compile/break2.rs: Modified file to pass test case.
* rust/compile/break_with_value_inside_loop.rs: New test.

---

[MahadMuhammad]

• This error code works, if we use only while loop. We need to improve this PR to also give this same error for for loop.
• You can view the same on godbolt

---

• Like if we try to use for loop, in the code tested from E0571.
• We expect to give error code like rustc i.e.,

error[E0571]: `break` with value from a `for` loop

[MahadMuhammad]

Updated ErrorCode according to ErrorCode enum class.

[philberty]

LGTM