[E0592] method or associated functions already defined with same names #2555
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CohenArthur
requested changes
Aug 16, 2023
|
|
||
| rust_error_at ( | ||
| r, "multiple candidates found for method %<%s%>", | ||
| r, ErrorCode::E0592, "duplicate definitions with name %<%s%>", |
There was a problem hiding this comment.
hm, not sure which message we should keep here and which error code we should use
There was a problem hiding this comment.
I think we should keep the original error message, as this one could confuse the user since the error will appear on the use site rather than the definition site
MahadMuhammad
changed the title
CohenArthur
approved these changes
Aug 17, 2023
|
@MahadMuhammad this has merge conflicts can you fix it up? |
|
@philberty, Sure thing. I'll do it :) |
|
@MahadMuhammad the tests are failing, once this is fixed I'll merge this |
MahadMuhammad
force-pushed
the
E0592
branch
2 times, most recently
from
d5cb245
to
4203600
Compare
P-E-P
approved these changes
Aug 30, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
…defined gcc/rust/ChangeLog: * typecheck/rust-hir-inherent-impl-overlap.h: Added rich location and errorcode. * typecheck/rust-hir-type-check-expr.cc (TypeCheckExpr::visit): likewise. gcc/testsuite/ChangeLog: * rust/compile/generics7.rs: Added Errorcode hint. * rust/compile/generics8.rs: Updated dejagnu comment. * rust/compile/issue-925.rs: Added Errorcode hint. Signed-off-by: Muhammad Mahad <mahadtxt@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Multiple candidated for
methodorfunction-E0592Running testcases:
gcc/testsuite/rust/compile/generics7.rsgcc/testsuite/rust/compile/issue-925.rsOutput:
gcc/rust/ChangeLog:
gcc/testsuite/ChangeLog: