Path resolution fixes #493
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philberty
force-pushed
the
phil/path-resolution-fixes
branch
from
f1c9aee
to
a1cc288
Compare
|
nit: s/untill/until in the commit message |
Name resolution tried to greedily resolve the entire CanonicalPath in one lookup which was ok for simple paths like A::B. This changes the name resolver to resolve each segment which allows the type resolution to determine the root path to be up until the segment is unresolved which will then require a PathProbe or its a failure. This will be required to support modules which extend the resolution to be much more generic than is assumed here. Addresses: #432
There are cases where the name resolver can fully resolve a path such as:
```rust
struct Foo(i32);
impl Foo{
fn new() { ... }
}
fn main() {
let a;
a = Foo::new();
}
```
This case does not require a PathProbe. This enhances the Path resolution
to iterate each segment untill we are unable to resolve the root segment
at that point we can fall back to a PathProbe and lookup any impl item that
might satisfy the path instead.
Addresses #432
In order to support modules the path expression will fail here since a module is not a value and does not have a TyTy type, so this is ok to continue the rest of resolution so long as there are more segments. Addresses: #432
philberty
force-pushed
the
phil/path-resolution-fixes
branch
from
9eaaec4
to
b3090f1
Compare
|
bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to support Modules, we need to do path resolution properly. The old code assumed a basic A::B but this is not generic enough in order to support modules.