Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace libc::c_void with () #465

Closed
bvssvni opened this issue Nov 7, 2015 · 3 comments
Closed

Replace libc::c_void with () #465

bvssvni opened this issue Nov 7, 2015 · 3 comments

Comments

@bvssvni
Copy link
Collaborator

bvssvni commented Nov 7, 2015

Glutin is planning to replace libc::c_void with (). See rust-windowing/glutin#652
@bvssvni bvssvni mentioned this issue Nov 7, 2015
Closed
4 tasks
@AngryLawyer AngryLawyer mentioned this issue Nov 16, 2015
Merged
@AngryLawyer
Copy link
Member

Hey @bvssvni
I've had a go at this, and think I've got it. I assume that, as sdl2_sys actually talks to the C libraries, that part needs to remain using c_void?
Also, there are several c callbacks in the code which I assume also need to stay that way?

Let me know what you think.

@bvssvni
Copy link
Collaborator Author

bvssvni commented Nov 16, 2015

It might be that () works when calling C libraries, but I think we can let them stay for the moment.

@AngryLawyer
Copy link
Member

Nice one. Thanks for the review!

@SimonSapin SimonSapin mentioned this issue Dec 1, 2015
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@AngryLawyer @bvssvni