Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Breaking change] Remove public exports of gl_common and libc #652

Merged
merged 2 commits into from
Nov 9, 2015

Conversation

tomaka
Copy link
Contributor

@tomaka tomaka commented Nov 4, 2015

@tomaka tomaka changed the title Remove public exports of gl_common and libc [Breaking change] Remove public exports of gl_common and libc Nov 4, 2015
@SSheldon
Copy link
Contributor

SSheldon commented Nov 7, 2015

Removing c_void seems good, but I will mention that *const () is not a C type, so you'll get a warning if you try to use it with an extern function.

I'm not sure if that's a concern here; if it it, the easiest way around it seems to be to make a no-variant enum and use that instead of (), like I did in SSheldon/rust-block@a1c5ef6.

@tomaka
Copy link
Contributor Author

tomaka commented Nov 9, 2015

After checking crates.io, it turns out that absolutely nobody uses that load thing, so I'm tempted to publish a minor version after this change instead of a major version.

@mitchmindtree
Copy link
Contributor

🙏

tomaka added a commit that referenced this pull request Nov 9, 2015
[Breaking change] Remove public exports of gl_common and libc
@tomaka tomaka merged commit bfc46c5 into master Nov 9, 2015
@tomaka tomaka deleted the rem-gl-common branch November 9, 2015 09:10
@mitchmindtree
Copy link
Contributor

🎉

@SimonSapin
Copy link
Contributor

Out of curiosity, why () rather than std::os::raw::c_void?

@tomaka
Copy link
Contributor Author

tomaka commented Nov 22, 2015

@SimonSapin Because I didn't know that existed -_-

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants