Copy non-Windows dynamic libs and symlinks to output #1102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Just like Windows, we should be copying the dynamic library to the target directory and deps directory. Otherwise, execution may fail, or, more likely, silently pick up the system libSDL2 and not the "bundled" one as asked. This is evident when trying to run tests on a system with the libsdl2 package uninstalled, where all the example tests fail unless they pick up the system .so.
Also copy all files and symlinks in the lib dir, to avoid worrying about platform specific prefixes/suffixes.
waych
changed the title
|
This addresses the current break in #1101 |
|
I find it surprising that we didn't notice this for this long, I was sure it worked fine on day 1. Perhaps there a was a change in build.rs one day that silently broke it on linux/macOS. Regardless, it looks good, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just like Windows, we should be copying the dynamic library to the
target directory and deps directory. Otherwise, execution may fail,
or, more likely, silently pick up the system libSDL2 and not the
"bundled" one as asked.
This is evident when trying to run tests on a system with the libsdl2
package uninstalled, where all the example tests fail unless they pick
up the system .so.