Add missing CoreHaptics framework #1219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This framework is used by the SDL_JOYSTICK module, but it is missing from Darwin builds. I have confirmed that this fixes my issues on my MacOS build. I have added the directive for the iOS builds, too, but that will need to be double-checked as I don't have a workflow for that.
|
Thanks! |
|
It looks like linking against CoreHaptics makes rust-sdl2 incompatible with <Catalina, since the framework is not present there. Is there a way to conditionally link it? |
|
@bigfarts there is surely a way, but please make a new ticket for that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This framework is used by the SDL_JOYSTICK module, but it is missing from Darwin builds.
I have confirmed that this fixes my issues on my MacOS build. I have added the directive for the iOS builds, too, but that will need to be double-checked as I don't have a workflow for that.