Use the num-traits crate directly instead of num #948
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmitmel
changed the title
dmitmel
force-pushed
the
switch-to-num-traits
branch
from
584210c
to
5ab9d1f
Compare
|
Sorry, for some reason I didn't receive a notification for this PR... Thanks! |
|
Should I remove |
|
It's true that the num_traits crate is used only to convert 5 enums... I think it'd be wise to remove entirely the dependency, indeed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that this crate uses only two features of
num-traits:num::FromPrimitive- used to convert raw integers to Rust enums. Is using an external library for this really necessary?num::ToPrimitive- used to convert colorsisizevalues to colors, replaced it withstd::convert::TryFrom.num::traits::cast- used in literally only one place, so I replaced it withstd::convert::TryInto.The
FromPrimitivetrait is located in thenum-traitscrate, so by depending on it instead of all ofnumI managed to reduce the total number of dependencies from 25 to 18. Also I took the opportunity and upgraded it from v0.1 to v0.2.If using
num-traitsforint <-> enumconversions is an overkill in your opinion, I can also open a PR to remove it from dependencies altogether.