Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rust: sort rust/helpers.c's #includes and add comment about it #1003

Closed
ojeda opened this issue Apr 22, 2023 · 6 comments
Closed

rust: sort rust/helpers.c's #includes and add comment about it #1003

ojeda opened this issue Apr 22, 2023 · 6 comments
Labels
good first issue Good for newcomers • lib Related to the `rust/` library.

Comments

@ojeda
Copy link
Member

ojeda commented Apr 22, 2023

The comment should be the same as the one found in rust/bindings/bindings_helper.h.

This requires submitting a proper patch to the LKML and the Rust for Linux mailing list. Please recall to test your changes, to use a proper title for the commit, to sign your commit under the Developer's Certificate of Origin and to add a Suggested-by: tag and aLink: tag to this issue. Please see https://rust-for-linux.com/contributing for details.

Please take this issue only if you are new to the kernel development process and you would like to use it as a test to submit your first patch to the kernel.
@ojeda ojeda added • lib Related to the `rust/` library. good first issue Good for newcomers labels Apr 22, 2023
@ariel-miculas
Copy link

I'll take this one.

@ojeda
Copy link
Member Author

ojeda commented Apr 25, 2023

Thanks -- please go ahead!

intel-lab-lkp pushed a commit to intel-lab-lkp/linux that referenced this issue Apr 25, 2023
@ariel-miculas @intel-lab-lkp
rust: Sort rust/helpers.c's #include directives
a163624 
Suggested-by: Miguel Ojeda <ojeda@kernel.org>
Link: Rust-for-Linux#1003
Signed-off-by: Ariel Miculas <amiculas@cisco.com>
intel-lab-lkp pushed a commit to intel-lab-lkp/linux that referenced this issue Apr 26, 2023
@ariel-miculas @intel-lab-lkp
rust: Sort rust/helpers.c's #include directives
f040d79 
Sort the #include directives of rust/helpers.c alphabetically and add a
comment specifying this.

Suggested-by: Miguel Ojeda <ojeda@kernel.org>
Link: Rust-for-Linux#1003
Signed-off-by: Ariel Miculas <amiculas@cisco.com>
intel-lab-lkp pushed a commit to intel-lab-lkp/linux that referenced this issue Apr 26, 2023
@ariel-miculas @intel-lab-lkp
rust: Sort rust/helpers.c's #include directives
719d107 
Sort the #include directives of rust/helpers.c alphabetically and add a
comment specifying this.

Suggested-by: Miguel Ojeda <ojeda@kernel.org>
Link: Rust-for-Linux#1003
Signed-off-by: Ariel Miculas <amiculas@cisco.com>
intel-lab-lkp pushed a commit to intel-lab-lkp/linux that referenced this issue Apr 26, 2023
@ariel-miculas @intel-lab-lkp
rust: helpers: sort includes alphabetically in rust/helpers.c
38370b2 
Sort the #include directives of rust/helpers.c alphabetically and add a
comment specifying this. The reason for this is to improve readability
and to be consistent with the other files with a similar approach within
'rust/'.

Suggested-by: Miguel Ojeda <ojeda@kernel.org>
Link: Rust-for-Linux#1003
Signed-off-by: Ariel Miculas <amiculas@cisco.com>
@KimWang906
Copy link

Why is this still open? Isn't this problem solved? Then I would like to contribute to solving this problem.

@ariel-miculas
Copy link

I have already sent a patch, not sure if it was merged or not.

@ojeda
Copy link
Member Author

ojeda commented Jun 29, 2023

I will pick it as soon as the merge window closes.

ojeda pushed a commit that referenced this issue Jul 19, 2023
@ariel-miculas @ojeda
rust: helpers: sort includes alphabetically in rust/helpers.c
7b92371 
Sort the #include directives of rust/helpers.c alphabetically and add a
comment specifying this. The reason for this is to improve readability
and to be consistent with the other files with a similar approach within
'rust/'.

Suggested-by: Miguel Ojeda <ojeda@kernel.org>
Link: #1003
Signed-off-by: Ariel Miculas <amiculas@cisco.com>
Reviewed-by: Martin Rodriguez Reboredo <yakoyoku@gmail.com>
Reviewed-by: Gary Guo <gary@garyguo.net>
Link: https://lore.kernel.org/r/20230426204923.16195-1-amiculas@cisco.com
Signed-off-by: Miguel Ojeda <ojeda@kernel.org>
ojeda pushed a commit that referenced this issue Jul 19, 2023
@ariel-miculas @ojeda
rust: helpers: sort includes alphabetically in rust/helpers.c
bee23a1 
Sort the #include directives of rust/helpers.c alphabetically and add a
comment specifying this. The reason for this is to improve readability
and to be consistent with the other files with a similar approach within
'rust/'.

Suggested-by: Miguel Ojeda <ojeda@kernel.org>
Link: #1003
Signed-off-by: Ariel Miculas <amiculas@cisco.com>
Reviewed-by: Martin Rodriguez Reboredo <yakoyoku@gmail.com>
Reviewed-by: Gary Guo <gary@garyguo.net>
Link: https://lore.kernel.org/r/20230426204923.16195-1-amiculas@cisco.com
Signed-off-by: Miguel Ojeda <ojeda@kernel.org>
ojeda pushed a commit that referenced this issue Jul 19, 2023
@ariel-miculas @ojeda
rust: helpers: sort includes alphabetically in rust/helpers.c
341faf2 
Sort the #include directives of rust/helpers.c alphabetically and add a
comment specifying this. The reason for this is to improve readability
and to be consistent with the other files with a similar approach within
'rust/'.

Suggested-by: Miguel Ojeda <ojeda@kernel.org>
Link: #1003
Signed-off-by: Ariel Miculas <amiculas@cisco.com>
Reviewed-by: Martin Rodriguez Reboredo <yakoyoku@gmail.com>
Reviewed-by: Gary Guo <gary@garyguo.net>
Link: https://lore.kernel.org/r/20230426204923.16195-1-amiculas@cisco.com
Signed-off-by: Miguel Ojeda <ojeda@kernel.org>
@ojeda
Copy link
Member Author

ojeda commented Jul 19, 2023

Applied to rust-next, thanks!

@ojeda ojeda closed this as completed Jul 19, 2023
ojeda pushed a commit that referenced this issue Aug 7, 2023
@ariel-miculas @ojeda
rust: helpers: sort includes alphabetically in rust/helpers.c
917b2e0 
Sort the #include directives of rust/helpers.c alphabetically and add a
comment specifying this. The reason for this is to improve readability
and to be consistent with the other files with a similar approach within
'rust/'.

Suggested-by: Miguel Ojeda <ojeda@kernel.org>
Link: #1003
Signed-off-by: Ariel Miculas <amiculas@cisco.com>
Reviewed-by: Martin Rodriguez Reboredo <yakoyoku@gmail.com>
Reviewed-by: Gary Guo <gary@garyguo.net>
Link: https://lore.kernel.org/r/20230426204923.16195-1-amiculas@cisco.com
Signed-off-by: Miguel Ojeda <ojeda@kernel.org>
vtta pushed a commit to vtta/linux-archive that referenced this issue Sep 29, 2023
@ariel-miculas @vtta
rust: helpers: sort includes alphabetically in rust/helpers.c
d47868c 
Sort the #include directives of rust/helpers.c alphabetically and add a
comment specifying this. The reason for this is to improve readability
and to be consistent with the other files with a similar approach within
'rust/'.

Suggested-by: Miguel Ojeda <ojeda@kernel.org>
Link: Rust-for-Linux#1003
Signed-off-by: Ariel Miculas <amiculas@cisco.com>
Reviewed-by: Martin Rodriguez Reboredo <yakoyoku@gmail.com>
Reviewed-by: Gary Guo <gary@garyguo.net>
Link: https://lore.kernel.org/r/20230426204923.16195-1-amiculas@cisco.com
Signed-off-by: Miguel Ojeda <ojeda@kernel.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers • lib Related to the `rust/` library.
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ojeda @ariel-miculas @KimWang906