Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix callback being called after dropping the stream #869

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix callback being called after dropping the stream #869

wants to merge 2 commits into from

Conversation

ZerNico
Copy link

@ZerNico ZerNico commented Mar 22, 2024

This fixes #771 by manually stopping the stream on drop.

@ZerNico
Copy link
Author

ZerNico commented Mar 25, 2024

When I think about it this might not be the best solution because StreamInner is still alive after dropping Stream

@ZerNico
Copy link
Author

ZerNico commented Mar 26, 2024

Now uses a weak reference to allow the inner stream to drop

@ZerNico
Copy link
Author

ZerNico commented Apr 26, 2024

Hey @est31, sorry to bother.
Do you think we could get this merged soon or is there anything left to do?
It's a pretty major bug on MacOS

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Stream dropped but audio callback still being called
1 participant
@ZerNico