Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switching to pure-rust mp3 decoder #256

Closed
est31 opened this issue Nov 16, 2019 · 3 comments · Fixed by #376
Closed

Switching to pure-rust mp3 decoder #256

est31 opened this issue Nov 16, 2019 · 3 comments · Fixed by #376

Comments

@est31
Copy link
Member

est31 commented Nov 16, 2019

We should consider switching to a pure-rust mp3 decoder.

There seem to be two alternatives, puremp3 and Symphonia:

We should study their quality as well as their speed to find out whether adoption is feasible.

@Shnatsel
Copy link
Contributor

Sonata has been renamed to Symphonia, and the author considers the MP3 decoder complete. That should be worth a look.

My first impulse is to get a dataset of mp3 files from archive.org, run them through the decoder and compare results with a known-good implementation. minimp3 README mentions a conformance test suite, but I'm not sure how to obtain it.

@est31
Copy link
Member Author

est31 commented Oct 19, 2020

@Shnatsel sounds like a good approach!

@TonalidadeHidrica
Copy link

Seems that puremp3 is currently unmaintained.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants