Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add optional Symphonia backend #376

Merged
merged 20 commits into from Jun 29, 2021
Merged

Add optional Symphonia backend #376

merged 20 commits into from Jun 29, 2021

Conversation

aschey
Copy link
Contributor

@aschey aschey commented Jun 27, 2021

Resolves #351, Resolves #256

This adds the option to use Symphonia as an alternative backend.

  • Symphonia decoders are all disabled by default and can be enabled using the symphonia-{codec name} features.
  • Symphonia decoders and the default decoders are mutually exclusive so the user must set default-features = false to enable any of the Symphonia features.
  • Added symphonia-all feature so the user doesn't have to enable each codec separately.
  • Added a compile error that should clearly explain the issue when both implementations of the same codec are enabled.
  • Updated the CI script to run against both the Symphonia codecs and the default codecs.
  • Updated the docs to explain how to use these features.

@aschey aschey mentioned this pull request Jun 27, 2021
@est31 est31 self-requested a review June 27, 2021 06:24
Cargo.toml Outdated Show resolved Hide resolved
Cargo.toml Outdated Show resolved Hide resolved
Cargo.toml Outdated Show resolved Hide resolved
Cargo.toml Outdated Show resolved Hide resolved
src/lib.rs Outdated Show resolved Hide resolved
Cargo.toml Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
build.rs Outdated Show resolved Hide resolved
src/decoder/mod.rs Outdated Show resolved Hide resolved
Copy link
Member

@est31 est31 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@est31 est31 merged commit 0988e8c into RustAudio:master Jun 29, 2021
@Shnatsel
Copy link
Contributor

@pdeljanov FYI - you've got users!

@aschey aschey deleted the symphonia branch July 5, 2021 23:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AAC + MPEG/AAC decoder Switching to pure-rust mp3 decoder
3 participants