Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin zeroize dependency to v1.3 and subtle to v2.4 #349

Merged
merged 2 commits into from
Jul 20, 2021
Merged

Conversation

newpavlov
Copy link
Member

zeroize in v1.4 has updated its MSRV to 1.51 breaking our MSRV promise. This PR pins its version to v1.3.x. subtle is also preemptively pinned to v2.4.

@newpavlov newpavlov requested a review from tarcieri July 19, 2021 11:05
@codecov-commenter
Copy link

Codecov Report

Merging #349 (eb84b7d) into master (3a2d1dc) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #349   +/-   ##
=======================================
  Coverage   89.40%   89.40%           
=======================================
  Files          42       42           
  Lines        2020     2020           
=======================================
  Hits         1806     1806           
  Misses        214      214           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3a2d1dc...eb84b7d. Read the comment docs.

@newpavlov
Copy link
Member Author

@tarcieri
Assuming you don't have objections, I can prepare PRs for other affected repositories.

Copy link
Member

@tarcieri tarcieri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@newpavlov sure, sounds good.

Just note that https://github.com/rustcrypto/elliptic-curves is MSRV 1.51 across the board and doesn't need it.

@newpavlov
Copy link
Member Author

The problem is that you may one day bump MSRV for zeroize v1.5, which would break MSRV build for the elliptic curve crates as well. So to be safe I think it's worth to pin 3rd party dependency versions for them as well.

@tarcieri
Copy link
Member

tarcieri commented Jul 19, 2021

Yeah sure, it's OK to pin, just make sure to pin it to 1.4 instead of 1.3 for elliptic-curves.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants