Refactor traits #315
Merged
Refactor traits #315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There were several modules that defined traits, including one called `traits`. This consolidates all of them under `traits`, retaining the previous module structure as internal submodules: - `keytraits` => `traits::keys` - `padding` => `traits::padding` - `traits` => `traits::encryption` Additionally this removes the traits that were re-exported at the toplevel, instead re-exporting them all under `traits`.
tarcieri
force-pushed
the
refactor-traits
branch
from
a56ebb3
to
cfacdf4
Compare
dignifiedquire
approved these changes
Apr 27, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were several modules that defined traits, including one called
traits.This consolidates all of them under
traits, retaining the previous module structure as internal submodules:keytraits=>traits::keyspadding=>traits::paddingtraits=>traits::encryptionAdditionally this removes the traits that were re-exported at the toplevel, instead re-exporting them all under
traits.cc @lumag